Skip to content

Commit

Permalink
Revert "mtd: mxc_nand: fix 2KiB pagesize NAND on i.MX27"
Browse files Browse the repository at this point in the history
This reverts commit 71b7d0d.

The problem which that commit attempted to fix was a bootloader issue,
which had been misunderstood. The 'fix' causes lots of false bad blocks
for existing users with sane firmware.

Thanks to Mathieu Berland for diagnosing the problem coherently.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
David Woodhouse authored and David Woodhouse committed Oct 20, 2009
1 parent 6f4e137 commit 1cc5239
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions drivers/mtd/nand/mxc_nand.c
Original file line number Diff line number Diff line change
Expand Up @@ -857,17 +857,6 @@ static void mxc_nand_command(struct mtd_info *mtd, unsigned command,
}
}

/* Define some generic bad / good block scan pattern which are used
* while scanning a device for factory marked good / bad blocks. */
static uint8_t scan_ff_pattern[] = { 0xff, 0xff };

static struct nand_bbt_descr smallpage_memorybased = {
.options = NAND_BBT_SCAN2NDPAGE,
.offs = 5,
.len = 1,
.pattern = scan_ff_pattern
};

static int __init mxcnd_probe(struct platform_device *pdev)
{
struct nand_chip *this;
Expand Down Expand Up @@ -984,10 +973,7 @@ static int __init mxcnd_probe(struct platform_device *pdev)
goto escan;
}

if (mtd->writesize == 2048) {
host->pagesize_2k = 1;
this->badblock_pattern = &smallpage_memorybased;
}
host->pagesize_2k = (mtd->writesize == 2048) ? 1 : 0;

if (this->ecc.mode == NAND_ECC_HW) {
switch (mtd->oobsize) {
Expand Down

0 comments on commit 1cc5239

Please sign in to comment.