Skip to content

Commit

Permalink
[PATCH] xen: x86: Use new macro for debugreg
Browse files Browse the repository at this point in the history
Make use of the 2 new macro set_debugreg and get_debugreg.

Signed-off-by: Vincent Hanquez <vincent.hanquez@cl.cam.ac.uk>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Vincent Hanquez authored and Linus Torvalds committed Jun 23, 2005
1 parent f501231 commit 1cc6f12
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 19 deletions.
2 changes: 1 addition & 1 deletion arch/i386/kernel/cpu/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ void __init cpu_init (void)

/* Clear all 6 debug registers: */

#define CD(register) __asm__("movl %0,%%db" #register ::"r"(0) );
#define CD(register) set_debugreg(0, register)

CD(0); CD(1); CD(2); CD(3); /* no db4 and db5 */; CD(6); CD(7);

Expand Down
12 changes: 6 additions & 6 deletions arch/i386/kernel/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -633,13 +633,13 @@ struct task_struct fastcall * __switch_to(struct task_struct *prev_p, struct tas
* Now maybe reload the debug registers
*/
if (unlikely(next->debugreg[7])) {
loaddebug(next, 0);
loaddebug(next, 1);
loaddebug(next, 2);
loaddebug(next, 3);
set_debugreg(current->thread.debugreg[0], 0);
set_debugreg(current->thread.debugreg[1], 1);
set_debugreg(current->thread.debugreg[2], 2);
set_debugreg(current->thread.debugreg[3], 3);
/* no 4 and 5 */
loaddebug(next, 6);
loaddebug(next, 7);
set_debugreg(current->thread.debugreg[6], 6);
set_debugreg(current->thread.debugreg[7], 7);
}

if (unlikely(prev->io_bitmap_ptr || next->io_bitmap_ptr))
Expand Down
2 changes: 1 addition & 1 deletion arch/i386/kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ int fastcall do_signal(struct pt_regs *regs, sigset_t *oldset)
* inside the kernel.
*/
if (unlikely(current->thread.debugreg[7])) {
loaddebug(&current->thread, 7);
set_debugreg(current->thread.debugreg[7], 7);
}

/* Whee! Actually deliver the signal. */
Expand Down
6 changes: 2 additions & 4 deletions arch/i386/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ fastcall void do_debug(struct pt_regs * regs, long error_code)
unsigned int condition;
struct task_struct *tsk = current;

__asm__ __volatile__("movl %%db6,%0" : "=r" (condition));
get_debugreg(condition, 6);

if (notify_die(DIE_DEBUG, "debug", regs, condition, error_code,
SIGTRAP) == NOTIFY_STOP)
Expand Down Expand Up @@ -727,9 +727,7 @@ fastcall void do_debug(struct pt_regs * regs, long error_code)
* the signal is delivered.
*/
clear_dr7:
__asm__("movl %0,%%db7"
: /* no output */
: "r" (0));
set_debugreg(0, 7);
return;

debug_vm86:
Expand Down
14 changes: 7 additions & 7 deletions arch/i386/power/cpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,13 @@ static void fix_processor_context(void)
* Now maybe reload the debug registers
*/
if (current->thread.debugreg[7]){
loaddebug(&current->thread, 0);
loaddebug(&current->thread, 1);
loaddebug(&current->thread, 2);
loaddebug(&current->thread, 3);
/* no 4 and 5 */
loaddebug(&current->thread, 6);
loaddebug(&current->thread, 7);
set_debugreg(current->thread.debugreg[0], 0);
set_debugreg(current->thread.debugreg[1], 1);
set_debugreg(current->thread.debugreg[2], 2);
set_debugreg(current->thread.debugreg[3], 3);
/* no 4 and 5 */
set_debugreg(current->thread.debugreg[6], 6);
set_debugreg(current->thread.debugreg[7], 7);
}

}
Expand Down

0 comments on commit 1cc6f12

Please sign in to comment.