Skip to content

Commit

Permalink
at86rf230: remove unnecessary state read
Browse files Browse the repository at this point in the history
This patch removes a unnecessary state read. The status value is never
evaluate after reading the state.

Also rename the status variable to dvdd, because this variable will be
used later.

Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Alexander Aring authored and David S. Miller committed Apr 26, 2014
1 parent 57e48ff commit 1cc9fc5
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions drivers/net/ieee802154/at86rf230.c
Original file line number Diff line number Diff line change
Expand Up @@ -969,13 +969,9 @@ static int at86rf230_irq_polarity(struct at86rf230_local *lp, int pol)
static int at86rf230_hw_init(struct at86rf230_local *lp)
{
int rc, irq_pol, irq_type;
u8 status;
u8 dvdd;
u8 csma_seed[2];

rc = at86rf230_read_subreg(lp, SR_TRX_STATUS, &status);
if (rc)
return rc;

rc = at86rf230_write_subreg(lp, SR_TRX_CMD, STATE_FORCE_TRX_OFF);
if (rc)
return rc;
Expand Down Expand Up @@ -1015,10 +1011,10 @@ static int at86rf230_hw_init(struct at86rf230_local *lp)
/* Wait the next SLEEP cycle */
msleep(100);

rc = at86rf230_read_subreg(lp, SR_DVDD_OK, &status);
rc = at86rf230_read_subreg(lp, SR_DVDD_OK, &dvdd);
if (rc)
return rc;
if (!status) {
if (!dvdd) {
dev_err(&lp->spi->dev, "DVDD error\n");
return -EINVAL;
}
Expand Down

0 comments on commit 1cc9fc5

Please sign in to comment.