Skip to content

Commit

Permalink
USB: gadget: f_mass_storage: use ?: instead of a macro
Browse files Browse the repository at this point in the history
This commit removes an "OR" macro defined in Mass Storage
Function in favour of a two argument version of "?:" operator
(which is a GCC extension).

Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Michal Nazarewicz authored and Greg Kroah-Hartman committed Nov 11, 2010
1 parent 17a9361 commit 1ccd792
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions drivers/usb/gadget/f_mass_storage.c
Original file line number Diff line number Diff line change
Expand Up @@ -2822,14 +2822,12 @@ static struct fsg_common *fsg_common_init(struct fsg_common *common,
i = 0x0399;
}
}
#define OR(x, y) ((x) ? (x) : (y))
snprintf(common->inquiry_string, sizeof common->inquiry_string,
"%-8s%-16s%04x",
OR(cfg->vendor_name, "Linux "),
"%-8s%-16s%04x", cfg->vendor_name ?: "Linux",
/* Assume product name dependent on the first LUN */
OR(cfg->product_name, common->luns->cdrom
cfg->product_name ?: (common->luns->cdrom
? "File-Stor Gadget"
: "File-CD Gadget "),
: "File-CD Gadget"),
i);


Expand All @@ -2848,14 +2846,13 @@ static struct fsg_common *fsg_common_init(struct fsg_common *common,
/* Tell the thread to start working */
common->thread_task =
kthread_create(fsg_main_thread, common,
OR(cfg->thread_name, "file-storage"));
cfg->thread_name ?: "file-storage");
if (IS_ERR(common->thread_task)) {
rc = PTR_ERR(common->thread_task);
goto error_release;
}
init_completion(&common->thread_notifier);
init_waitqueue_head(&common->fsg_wait);
#undef OR


/* Information */
Expand Down

0 comments on commit 1ccd792

Please sign in to comment.