Skip to content

Commit

Permalink
mISDN: Fix overlapping data access
Browse files Browse the repository at this point in the history
Remove code rewriting a buffer by itself.
This fix bug 12970 on bugzilla.kernel.org.

Signed-off-by: Karsten Keil <keil@b1-systems.de>
  • Loading branch information
Karsten Keil committed Jun 11, 2009
1 parent 8a745b9 commit 1ce1513
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions drivers/isdn/mISDN/dsp_pipeline.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,20 +55,19 @@ static ssize_t
attr_show_args(struct device *dev, struct device_attribute *attr, char *buf)
{
struct mISDN_dsp_element *elem = dev_get_drvdata(dev);
ssize_t len = 0;
int i = 0;
int i;
char *p = buf;

*buf = 0;
for (; i < elem->num_args; ++i)
len = sprintf(buf, "%sName: %s\n%s%s%sDescription: %s\n"
"\n", buf,
for (i = 0; i < elem->num_args; i++)
p += sprintf(p, "Name: %s\n%s%s%sDescription: %s\n\n",
elem->args[i].name,
elem->args[i].def ? "Default: " : "",
elem->args[i].def ? elem->args[i].def : "",
elem->args[i].def ? "\n" : "",
elem->args[i].desc);

return len;
return p - buf;
}

static struct device_attribute element_attributes[] = {
Expand Down

0 comments on commit 1ce1513

Please sign in to comment.