Skip to content

Commit

Permalink
PCI: use better error return values in aer_inject
Browse files Browse the repository at this point in the history
Replaced some error return values in aer_inject. Use -ENODEV when we
can't find a device and -ENOTTY when the device does not support PCIe AER.

Acked-by: Huang Ying <ying.huang@intel.com>
Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
  • Loading branch information
Andrew Patterson authored and Jesse Barnes committed Nov 4, 2009
1 parent cc5d153 commit 1d02435
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/pci/pcie/aer/aer_inject.c
Original file line number Diff line number Diff line change
Expand Up @@ -326,23 +326,23 @@ static int aer_inject(struct aer_error_inj *einj)

dev = pci_get_domain_bus_and_slot((int)einj->domain, einj->bus, devfn);
if (!dev)
return -EINVAL;
return -ENODEV;
rpdev = pcie_find_root_port(dev);
if (!rpdev) {
ret = -EINVAL;
ret = -ENOTTY;
goto out_put;
}

pos_cap_err = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);
if (!pos_cap_err) {
ret = -EIO;
ret = -ENOTTY;
goto out_put;
}
pci_read_config_dword(dev, pos_cap_err + PCI_ERR_UNCOR_SEVER, &sever);

rp_pos_cap_err = pci_find_ext_capability(rpdev, PCI_EXT_CAP_ID_ERR);
if (!rp_pos_cap_err) {
ret = -EIO;
ret = -ENOTTY;
goto out_put;
}

Expand Down

0 comments on commit 1d02435

Please sign in to comment.