Skip to content

Commit

Permalink
[ICMP]: Section conflict between icmp_sk_init/icmp_sk_exit.
Browse files Browse the repository at this point in the history
Functions from __exit section should not be called from ones in __init
section. Fix this conflict.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Denis V. Lunev authored and David S. Miller committed Feb 29, 2008
1 parent 4a80f27 commit 1d1c8d1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/ipv4/icmp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1198,7 +1198,9 @@ int __net_init icmp_sk_init(struct net *net)
return 0;

fail:
icmp_sk_exit(net);
for_each_possible_cpu(i)
sk_release_kernel(net->ipv4.icmp_sk[i]);
kfree(net->ipv4.icmp_sk);
return err;
}

Expand Down

0 comments on commit 1d1c8d1

Please sign in to comment.