Skip to content

Commit

Permalink
power/smb347-charger.c: set IRQF_ONESHOT flag to ensure IRQ request
Browse files Browse the repository at this point in the history
Since commit 1c6c695 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request may fail.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
  • Loading branch information
Valentin Rothberg authored and Sebastian Reichel committed Mar 2, 2015
1 parent f46bf82 commit 1d93b85
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/power/smb347-charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -842,7 +842,8 @@ static int smb347_irq_init(struct smb347_charger *smb,
goto fail;

ret = request_threaded_irq(irq, NULL, smb347_interrupt,
IRQF_TRIGGER_FALLING, client->name, smb);
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
client->name, smb);
if (ret < 0)
goto fail_gpio;

Expand Down

0 comments on commit 1d93b85

Please sign in to comment.