Skip to content

Commit

Permalink
[NETDRVR] lib82596, netxen: delete pointless tests from irq handler
Browse files Browse the repository at this point in the history
Remove always-false tests in irq handler.

Also a few other minor cleanups.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Jeff Garzik committed Oct 23, 2007
1 parent 06efcad commit 1daec86
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 16 deletions.
8 changes: 1 addition & 7 deletions drivers/net/lib82596.c
Original file line number Diff line number Diff line change
Expand Up @@ -1124,12 +1124,6 @@ static irqreturn_t i596_interrupt(int irq, void *dev_id)
struct i596_dma *dma;
unsigned short status, ack_cmd = 0;

if (dev == NULL) {
printk(KERN_WARNING "%s: irq %d for unknown device.\n",
__FUNCTION__, irq);
return IRQ_NONE;
}

lp = netdev_priv(dev);
dma = lp->dma;

Expand All @@ -1140,7 +1134,7 @@ static irqreturn_t i596_interrupt(int irq, void *dev_id)

DEB(DEB_INTS, printk(KERN_DEBUG
"%s: i596 interrupt, IRQ %d, status %4.4x.\n",
dev->name, irq, status));
dev->name, dev->irq, status));

ack_cmd = status & 0xf000;

Expand Down
11 changes: 2 additions & 9 deletions drivers/net/netxen/netxen_nic_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1268,17 +1268,10 @@ netxen_handle_int(struct netxen_adapter *adapter, struct net_device *netdev)
*/
irqreturn_t netxen_intr(int irq, void *data)
{
struct netxen_adapter *adapter;
struct net_device *netdev;
struct netxen_adapter *adapter = data;
struct net_device *netdev = adapter->netdev;
u32 our_int = 0;

if (unlikely(!irq)) {
return IRQ_NONE; /* Not our interrupt */
}

adapter = (struct netxen_adapter *)data;
netdev = adapter->netdev;

if (!(adapter->flags & NETXEN_NIC_MSI_ENABLED)) {
our_int = readl(NETXEN_CRB_NORMALIZE(adapter, CRB_INT_VECTOR));
/* not our interrupt */
Expand Down

0 comments on commit 1daec86

Please sign in to comment.