Skip to content

Commit

Permalink
[PATCH] libertas: don't tear down netdev in libertas_activate_card
Browse files Browse the repository at this point in the history
libertas_activate_card() doesn't create the netdev, and shouldn't
free it on error.  The caller of libertas_activate_card() is
responsible for cleaning up errors from libertas_add_card(),
not libertas_activate_card().

Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Dan Williams authored and John W. Linville committed Jun 11, 2007
1 parent c723683 commit 1db733e
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/wireless/libertas/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -878,8 +878,6 @@ int libertas_activate_card(wlan_private *priv, char *fw_name)
/* Stop the thread servicing the interrupts */
wake_up_interruptible(&priv->mainthread.waitq);
wlan_terminate_thread(&priv->mainthread);
kfree(priv->adapter);
free_netdev(dev);
done:
lbs_deb_leave_args(LBS_DEB_NET, "ret %d", ret);
return ret;
Expand Down

0 comments on commit 1db733e

Please sign in to comment.