Skip to content

Commit

Permalink
[SCSI] hptiop: Eliminate a NULL pointer dereference
Browse files Browse the repository at this point in the history
The end of the function is reachable both when host is and is not NULL.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression E,E1;
identifier f;
statement S1,S2,S3;
@@

if ((E == NULL && ...) || ...)
{
  ... when != if (...) S1 else S2
      when != E = E1
* E->f
  ... when any
  return ...;
}
else S3
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
  • Loading branch information
Julia Lawall authored and James Bottomley committed Jul 27, 2010
1 parent 2a1b7e5 commit 1db90ea
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/hptiop.c
Original file line number Diff line number Diff line change
Expand Up @@ -1157,7 +1157,7 @@ static int __devinit hptiop_probe(struct pci_dev *pcidev,
disable_pci_device:
pci_disable_device(pcidev);

dprintk("scsi%d: hptiop_probe fail\n", host->host_no);
dprintk("scsi%d: hptiop_probe fail\n", host ? host->host_no : 0);
return -ENODEV;
}

Expand Down

0 comments on commit 1db90ea

Please sign in to comment.