Skip to content

Commit

Permalink
thermal: rcar: tidyup registration failure case
Browse files Browse the repository at this point in the history
Current rcar_thermal driver didn't care about rcar_theraml_irq_disable()
when registration failure case on _probe(), and _remove().
And, it returns without unregistering thermal zone when
registration failure case on _probe().
This patch fixes these issue.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
  • Loading branch information
Kuninori Morimoto authored and Zhang Rui committed Apr 2, 2013
1 parent fa0d654 commit 1dc2082
Showing 1 changed file with 16 additions and 7 deletions.
23 changes: 16 additions & 7 deletions drivers/thermal/rcar_thermal.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,12 +419,15 @@ static int rcar_thermal_probe(struct platform_device *pdev)
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv) {
dev_err(dev, "Could not allocate priv\n");
return -ENOMEM;
ret = -ENOMEM;
goto error_unregister;
}

priv->base = devm_ioremap_resource(dev, res);
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);
if (IS_ERR(priv->base)) {
ret = PTR_ERR(priv->base);
goto error_unregister;
}

priv->common = common;
priv->id = i;
Expand All @@ -443,10 +446,10 @@ static int rcar_thermal_probe(struct platform_device *pdev)
goto error_unregister;
}

list_move_tail(&priv->list, &common->head);

if (rcar_has_irq_support(priv))
rcar_thermal_irq_enable(priv);

list_move_tail(&priv->list, &common->head);
}

platform_set_drvdata(pdev, common);
Expand All @@ -456,8 +459,11 @@ static int rcar_thermal_probe(struct platform_device *pdev)
return 0;

error_unregister:
rcar_thermal_for_each_priv(priv, common)
rcar_thermal_for_each_priv(priv, common) {
thermal_zone_device_unregister(priv->zone);
if (rcar_has_irq_support(priv))
rcar_thermal_irq_disable(priv);
}

return ret;
}
Expand All @@ -467,8 +473,11 @@ static int rcar_thermal_remove(struct platform_device *pdev)
struct rcar_thermal_common *common = platform_get_drvdata(pdev);
struct rcar_thermal_priv *priv;

rcar_thermal_for_each_priv(priv, common)
rcar_thermal_for_each_priv(priv, common) {
thermal_zone_device_unregister(priv->zone);
if (rcar_has_irq_support(priv))
rcar_thermal_irq_disable(priv);
}

platform_set_drvdata(pdev, NULL);

Expand Down

0 comments on commit 1dc2082

Please sign in to comment.