Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 99493
b: refs/heads/master
c: cd7a4e9
h: refs/heads/master
i:
  99491: a5a6e4c
v: v3
  • Loading branch information
Andreas Herrmann authored and Ingo Molnar committed Jun 12, 2008
1 parent 5fe49d8 commit 1dc4f7a
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 22 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 97cfab6ac4ddfda0d722393bbf46cc40bc332107
refs/heads/master: cd7a4e936d345ab4cb49d68192d90bd4e4c58458
2 changes: 0 additions & 2 deletions trunk/arch/x86/kernel/cpu/addon_cpuid_features.c
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@

/*
* Routines to indentify additional cpu features that are scattered in
* cpuid space.
*/

#include <linux/cpu.h>

#include <asm/pat.h>
Expand Down
29 changes: 14 additions & 15 deletions trunk/arch/x86/mm/pat.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ enum {
PAT_UC_MINUS = 7, /* UC, but can be overriden by MTRR */
};

#define PAT(x,y) ((u64)PAT_ ## y << ((x)*8))
#define PAT(x, y) ((u64)PAT_ ## y << ((x)*8))

void pat_init(void)
{
Expand Down Expand Up @@ -100,8 +100,8 @@ void pat_init(void)
* 011 UC _PAGE_CACHE_UC
* PAT bit unused
*/
pat = PAT(0,WB) | PAT(1,WC) | PAT(2,UC_MINUS) | PAT(3,UC) |
PAT(4,WB) | PAT(5,WC) | PAT(6,UC_MINUS) | PAT(7,UC);
pat = PAT(0, WB) | PAT(1, WC) | PAT(2, UC_MINUS) | PAT(3, UC) |
PAT(4, WB) | PAT(5, WC) | PAT(6, UC_MINUS) | PAT(7, UC);

/* Boot CPU check */
if (!boot_pat_state)
Expand All @@ -117,11 +117,11 @@ void pat_init(void)
static char *cattr_name(unsigned long flags)
{
switch (flags & _PAGE_CACHE_MASK) {
case _PAGE_CACHE_UC: return "uncached";
case _PAGE_CACHE_UC_MINUS: return "uncached-minus";
case _PAGE_CACHE_WB: return "write-back";
case _PAGE_CACHE_WC: return "write-combining";
default: return "broken";
case _PAGE_CACHE_UC: return "uncached";
case _PAGE_CACHE_UC_MINUS: return "uncached-minus";
case _PAGE_CACHE_WB: return "write-back";
case _PAGE_CACHE_WC: return "write-combining";
default: return "broken";
}
}

Expand Down Expand Up @@ -536,11 +536,11 @@ int phys_mem_access_prot_allowed(struct file *file, unsigned long pfn,
* we maintain the tradition of paranoia in this code.
*/
if (!pat_wc_enabled &&
! ( boot_cpu_has(X86_FEATURE_MTRR) ||
boot_cpu_has(X86_FEATURE_K6_MTRR) ||
boot_cpu_has(X86_FEATURE_CYRIX_ARR) ||
boot_cpu_has(X86_FEATURE_CENTAUR_MCR)) &&
(pfn << PAGE_SHIFT) >= __pa(high_memory)) {
!(boot_cpu_has(X86_FEATURE_MTRR) ||
boot_cpu_has(X86_FEATURE_K6_MTRR) ||
boot_cpu_has(X86_FEATURE_CYRIX_ARR) ||
boot_cpu_has(X86_FEATURE_CENTAUR_MCR)) &&
(pfn << PAGE_SHIFT) >= __pa(high_memory)) {
flags = _PAGE_CACHE_UC;
}
#endif
Expand All @@ -562,7 +562,7 @@ int phys_mem_access_prot_allowed(struct file *file, unsigned long pfn,
return 0;

if (pfn <= max_pfn_mapped &&
ioremap_change_attr((unsigned long)__va(offset), size, flags) < 0) {
ioremap_change_attr((unsigned long)__va(offset), size, flags) < 0) {
free_memtype(offset, offset + size);
printk(KERN_INFO
"%s:%d /dev/mem ioremap_change_attr failed %s for %Lx-%Lx\n",
Expand Down Expand Up @@ -600,4 +600,3 @@ void unmap_devmem(unsigned long pfn, unsigned long size, pgprot_t vma_prot)

free_memtype(addr, addr + size);
}

6 changes: 2 additions & 4 deletions trunk/include/asm-x86/pat.h
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@

#ifndef _ASM_PAT_H
#define _ASM_PAT_H 1
#define _ASM_PAT_H

#include <linux/types.h>

#ifdef CONFIG_X86_PAT
extern int pat_wc_enabled;
extern void validate_pat_support(struct cpuinfo_x86 *c);
#else
static const int pat_wc_enabled = 0;
static const int pat_wc_enabled;
static inline void validate_pat_support(struct cpuinfo_x86 *c) { }
#endif

Expand All @@ -21,4 +20,3 @@ extern int free_memtype(u64 start, u64 end);
extern void pat_disable(char *reason);

#endif

0 comments on commit 1dc4f7a

Please sign in to comment.