Skip to content

Commit

Permalink
tlan: cancel work at remove path
Browse files Browse the repository at this point in the history
the work has been scheduled from interrupt, and not been
cancelled when the driver is unloaded, which doesn't remove
the work item from the global workqueue. call the
cancel_work_sync when the driver is removed (rmmod'ed).

Cc: Sriram <srk@ti.com>
Cc: Cyril Chemparathy <cyril@ti.com>
Cc: Vinay Hegde <vinay.hegde@ti.com>
Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Devendra Naga authored and David S. Miller committed Apr 16, 2013
1 parent d5d427c commit 1e0a8b1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/ethernet/ti/tlan.c
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ static void tlan_remove_one(struct pci_dev *pdev)
free_netdev(dev);

pci_set_drvdata(pdev, NULL);
cancel_work_sync(&priv->tlan_tqueue);
}

static void tlan_start(struct net_device *dev)
Expand Down

0 comments on commit 1e0a8b1

Please sign in to comment.