Skip to content

Commit

Permalink
[PATCH] x86: use probe_kernel_address in handle_BUG()
Browse files Browse the repository at this point in the history
Avoid possible deadlock on a BUG() inside down_write(mmap_sem).  The deadlock
can only occur if something has gone horridly wrong, because a fault here
shouldn't happen.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andrew Morton authored and Linus Torvalds committed Sep 27, 2006
1 parent 1b79e55 commit 1e2af92
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions arch/i386/kernel/traps.c
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include <linux/kprobes.h>
#include <linux/kexec.h>
#include <linux/unwind.h>
#include <linux/uaccess.h>

#ifdef CONFIG_EISA
#include <linux/ioport.h>
Expand All @@ -40,7 +41,6 @@

#include <asm/processor.h>
#include <asm/system.h>
#include <asm/uaccess.h>
#include <asm/io.h>
#include <asm/atomic.h>
#include <asm/debugreg.h>
Expand Down Expand Up @@ -409,7 +409,7 @@ static void handle_BUG(struct pt_regs *regs)

if (eip < PAGE_OFFSET)
return;
if (__get_user(ud2, (unsigned short __user *)eip))
if (probe_kernel_address((unsigned short __user *)eip, ud2))
return;
if (ud2 != 0x0b0f)
return;
Expand All @@ -422,7 +422,8 @@ static void handle_BUG(struct pt_regs *regs)
char *file;
char c;

if (__get_user(line, (unsigned short __user *)(eip + 2)))
if (probe_kernel_address((unsigned short __user *)(eip + 2),
line))
break;
if (__get_user(file, (char * __user *)(eip + 4)) ||
(unsigned long)file < PAGE_OFFSET || __get_user(c, file))
Expand Down

0 comments on commit 1e2af92

Please sign in to comment.