Skip to content

Commit

Permalink
s2io: return PCI_ERS_RESULT_DISCONNECT on permanent failure
Browse files Browse the repository at this point in the history
PCI drivers that implement the struct pci_error_handlers' error_detected
callback should return PCI_ERS_RESULT_DISCONNECT if the state passed in is
pci_channel_io_perm_failure. This patch fixes the issue for s2io.

Signed-off-by: Dean Nelson <dnelson@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dean Nelson authored and David S. Miller committed Aug 2, 2009
1 parent fbc663c commit 1e3c8bd
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/s2io.c
Original file line number Diff line number Diff line change
Expand Up @@ -8636,6 +8636,9 @@ static pci_ers_result_t s2io_io_error_detected(struct pci_dev *pdev,

netif_device_detach(netdev);

if (state == pci_channel_io_perm_failure)
return PCI_ERS_RESULT_DISCONNECT;

if (netif_running(netdev)) {
/* Bring down the card, while avoiding PCI I/O */
do_s2io_card_down(sp, 0);
Expand Down

0 comments on commit 1e3c8bd

Please sign in to comment.