Skip to content

Commit

Permalink
[PATCH] md: remove slashes from disk names when creation dev names in…
Browse files Browse the repository at this point in the history
… sysfs

e.g. The sx8 driver uses names like sx8/0.

This would make a md component dev name like

   /sys/block/md0/md/dev-sx8/0

which is not allowed.  So we change the '/' to '!' just like
fs/partitions/check.c(register_disk) does.

Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Neil Brown authored and Linus Torvalds committed Jan 12, 2006
1 parent 2a7e2f7 commit 1edf80d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/md/md.c
Original file line number Diff line number Diff line change
Expand Up @@ -1238,6 +1238,7 @@ static int bind_rdev_to_array(mdk_rdev_t * rdev, mddev_t * mddev)
mdk_rdev_t *same_pdev;
char b[BDEVNAME_SIZE], b2[BDEVNAME_SIZE];
struct kobject *ko;
char *s;

if (rdev->mddev) {
MD_BUG();
Expand Down Expand Up @@ -1277,6 +1278,8 @@ static int bind_rdev_to_array(mdk_rdev_t * rdev, mddev_t * mddev)
bdevname(rdev->bdev,b);
if (kobject_set_name(&rdev->kobj, "dev-%s", b) < 0)
return -ENOMEM;
while ( (s=strchr(rdev->kobj.k_name, '/')) != NULL)
*s = '!';

list_add(&rdev->same_set, &mddev->disks);
rdev->mddev = mddev;
Expand Down

0 comments on commit 1edf80d

Please sign in to comment.