Skip to content

Commit

Permalink
target: Fix inverted logic in SE_DEV_ALUA_SUPPORT_STATE_STORE
Browse files Browse the repository at this point in the history
Fix inverted logic in SE_DEV_ALUA_SUPPORT_STATE_STORE for setting
the supported ALUA access states via configfs, originally introduced
in commit b0a382c.

A value of 1 should enable the support, not disable it.

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
Cc: <stable@vger.kernel.org> # v3.14+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Sebastian Herbszt authored and Nicholas Bellinger committed Sep 17, 2014
1 parent 096b499 commit 1f0b030
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/target/target_core_configfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -2363,7 +2363,7 @@ static ssize_t target_core_alua_tg_pt_gp_store_attr_alua_support_##_name(\
pr_err("Invalid value '%ld', must be '0' or '1'\n", tmp); \
return -EINVAL; \
} \
if (!tmp) \
if (tmp) \
t->_var |= _bit; \
else \
t->_var &= ~_bit; \
Expand Down

0 comments on commit 1f0b030

Please sign in to comment.