Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 312643
b: refs/heads/master
c: d2cfdb0
h: refs/heads/master
i:
  312641: cfd4790
  312639: 0330956
v: v3
  • Loading branch information
Laxman Dewangan authored and Mark Brown committed Jul 17, 2012
1 parent 75d54f4 commit 1f34568
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 24 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 8a165df7a915cb212f41c1dec9abc5ac8f8ee6b6
refs/heads/master: d2cfdb055d77f8d0864d75adfc1a3f0e0ec40e69
33 changes: 22 additions & 11 deletions trunk/Documentation/devicetree/bindings/mfd/tps65910.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,12 @@ Required properties:
tps65911: vrtc, vio, vdd1, vdd3, vddctrl, ldo1, ldo2, ldo3, ldo4, ldo5,
ldo6, ldo7, ldo8

Optional properties:
- ti,vmbch-threshold: (tps65911) main battery charged threshold
comparator. (see VMBCH_VSEL in TPS65910 datasheet)
- ti,vmbch2-threshold: (tps65911) main battery discharged threshold
comparator. (see VMBCH_VSEL in TPS65910 datasheet)
- ti,en-gpio-sleep: enable sleep control for gpios
There should be 9 entries here, one for each gpio.
- xxx-supply: Input voltage supply regulator.
Missing of these properties will be assume as there is no supply regulator
for that input pins and always powered on.
The valid input supply properties are:
These entries are require if regulators are enabled for a device. Missing of these
properties can cause the regulator registration fails.
If some of input supply is powered through battery or always-on supply then
also it is require to have these parameters with proper node handle of always
on power supply.
tps65910:
vcc1-supply: VDD1 input.
vcc2-supply: VDD2 input.
Expand All @@ -55,6 +50,16 @@ Optional properties:
vcc7-supply: VRTC input.
vccio-supply: VIO input.

Optional properties:
- ti,vmbch-threshold: (tps65911) main battery charged threshold
comparator. (see VMBCH_VSEL in TPS65910 datasheet)
- ti,vmbch2-threshold: (tps65911) main battery discharged threshold
comparator. (see VMBCH_VSEL in TPS65910 datasheet)
- ti,en-ck32k-xtal: enable external 32-kHz crystal oscillator (see CK32K_CTRL
in TPS6591X datasheet)
- ti,en-gpio-sleep: enable sleep control for gpios
There should be 9 entries here, one for each gpio.

Regulator Optional properties:
- ti,regulator-ext-sleep-control: enable external sleep
control through external inputs [0 (not enabled), 1 (EN1), 2 (EN2) or 4(EN3)]
Expand All @@ -79,8 +84,14 @@ Example:

ti,en-gpio-sleep = <0 0 1 0 0 0 0 0 0>;

vcc7-supply = <&reg_parent>;
vcc1-supply = <&reg_parent>;
vcc2-supply = <&some_reg>;
vcc3-supply = <...>;
vcc4-supply = <...>;
vcc5-supply = <...>;
vcc6-supply = <...>;
vcc7-supply = <...>;
vccio-supply = <...>;

regulators {
#address-cells = <1>;
Expand Down
11 changes: 1 addition & 10 deletions trunk/drivers/regulator/tps65910-regulator.c
Original file line number Diff line number Diff line change
Expand Up @@ -1001,9 +1001,6 @@ static struct tps65910_board *tps65910_parse_dt_reg_data(
*tps65910_reg_matches = matches;

for (idx = 0; idx < count; idx++) {
struct tps_info *info = matches[idx].driver_data;
char in_supply[32]; /* 32 is max size of property name */

if (!matches[idx].init_data || !matches[idx].of_node)
continue;

Expand All @@ -1015,12 +1012,6 @@ static struct tps65910_board *tps65910_parse_dt_reg_data(
if (!ret)
pmic_plat_data->regulator_ext_sleep_control[idx] = prop;

if (info->vin_name) {
snprintf(in_supply, 32, "%s-supply", info->vin_name);
if (of_find_property(np, in_supply, 0))
pmic_plat_data->input_supply[idx] =
info->vin_name;
}
}

return pmic_plat_data;
Expand Down Expand Up @@ -1123,7 +1114,7 @@ static __devinit int tps65910_probe(struct platform_device *pdev)
pmic->info[i] = info;

pmic->desc[i].name = info->name;
pmic->desc[i].supply_name = pmic_plat_data->input_supply[i];
pmic->desc[i].supply_name = info->vin_name;
pmic->desc[i].id = i;
pmic->desc[i].n_voltages = info->n_voltages;
pmic->desc[i].enable_time = info->enable_time_us;
Expand Down
2 changes: 0 additions & 2 deletions trunk/include/linux/mfd/tps65910.h
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,6 @@ struct tps65910_sleep_keepon_data {
/**
* struct tps65910_board
* Board platform data may be used to initialize regulators.
* @input_supply: Name of input supply regulator.
*/

struct tps65910_board {
Expand All @@ -812,7 +811,6 @@ struct tps65910_board {
struct tps65910_sleep_keepon_data *slp_keepon;
bool en_gpio_sleep[TPS6591X_MAX_NUM_GPIO];
unsigned long regulator_ext_sleep_control[TPS65910_NUM_REGS];
const char *input_supply[TPS65910_NUM_REGS];
struct regulator_init_data *tps65910_pmic_init_data[TPS65910_NUM_REGS];
};

Expand Down

0 comments on commit 1f34568

Please sign in to comment.