Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 93927
b: refs/heads/master
c: e19166d
h: refs/heads/master
i:
  93925: 7a10ec1
  93923: 5faac1b
  93919: d996bd7
v: v3
  • Loading branch information
Jeff Garzik authored and James Bottomley committed Apr 25, 2008
1 parent 3975961 commit 1f44637
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 19 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 8911c9e3343c647b59727b47b10feca7ee9ac9c3
refs/heads/master: e19166d5df10be0ea404c4e346cf6be93bfb1d63
7 changes: 1 addition & 6 deletions trunk/drivers/scsi/aha152x.c
Original file line number Diff line number Diff line change
Expand Up @@ -1432,15 +1432,10 @@ static void run(struct work_struct *work)
*/
static irqreturn_t intr(int irqno, void *dev_id)
{
struct Scsi_Host *shpnt = (struct Scsi_Host *)dev_id;
struct Scsi_Host *shpnt = dev_id;
unsigned long flags;
unsigned char rev, dmacntrl0;

if (!shpnt) {
printk(KERN_ERR "aha152x: catched interrupt %d for unknown controller.\n", irqno);
return IRQ_NONE;
}

/*
* Read a couple of registers that are known to not be all 1's. If
* we read all 1's (-1), that means that either:
Expand Down
11 changes: 4 additions & 7 deletions trunk/drivers/scsi/eata.c
Original file line number Diff line number Diff line change
Expand Up @@ -2286,17 +2286,14 @@ static void flush_dev(struct scsi_device *dev, unsigned long cursec,
}
}

static irqreturn_t ihdlr(int irq, struct Scsi_Host *shost)
static irqreturn_t ihdlr(struct Scsi_Host *shost)
{
struct scsi_cmnd *SCpnt;
unsigned int i, k, c, status, tstatus, reg;
struct mssp *spp;
struct mscp *cpp;
struct hostdata *ha = (struct hostdata *)shost->hostdata;

if (shost->irq != irq)
panic("%s: ihdlr, irq %d, shost->irq %d.\n", ha->board_name, irq,
shost->irq);
int irq = shost->irq;

/* Check if this board need to be serviced */
if (!(inb(shost->io_port + REG_AUX_STATUS) & IRQ_ASSERTED))
Expand Down Expand Up @@ -2535,7 +2532,7 @@ static irqreturn_t ihdlr(int irq, struct Scsi_Host *shost)
return IRQ_NONE;
}

static irqreturn_t do_interrupt_handler(int irq, void *shap)
static irqreturn_t do_interrupt_handler(int dummy, void *shap)
{
struct Scsi_Host *shost;
unsigned int j;
Expand All @@ -2548,7 +2545,7 @@ static irqreturn_t do_interrupt_handler(int irq, void *shap)
shost = sh[j];

spin_lock_irqsave(shost->host_lock, spin_flags);
ret = ihdlr(irq, shost);
ret = ihdlr(shost);
spin_unlock_irqrestore(shost->host_lock, spin_flags);
return ret;
}
Expand Down
9 changes: 4 additions & 5 deletions trunk/drivers/scsi/u14-34f.c
Original file line number Diff line number Diff line change
Expand Up @@ -1715,13 +1715,12 @@ static void flush_dev(struct scsi_device *dev, unsigned long cursec, unsigned in

}

static irqreturn_t ihdlr(int irq, unsigned int j) {
static irqreturn_t ihdlr(unsigned int j)
{
struct scsi_cmnd *SCpnt;
unsigned int i, k, c, status, tstatus, reg, ret;
struct mscp *spp, *cpp;

if (sh[j]->irq != irq)
panic("%s: ihdlr, irq %d, sh[j]->irq %d.\n", BN(j), irq, sh[j]->irq);
int irq = sh[j]->irq;

/* Check if this board need to be serviced */
if (!((reg = inb(sh[j]->io_port + REG_SYS_INTR)) & IRQ_ASSERTED)) goto none;
Expand Down Expand Up @@ -1935,7 +1934,7 @@ static irqreturn_t do_interrupt_handler(int irq, void *shap) {
if ((j = (unsigned int)((char *)shap - sha)) >= num_boards) return IRQ_NONE;

spin_lock_irqsave(sh[j]->host_lock, spin_flags);
ret = ihdlr(irq, j);
ret = ihdlr(j);
spin_unlock_irqrestore(sh[j]->host_lock, spin_flags);
return ret;
}
Expand Down

0 comments on commit 1f44637

Please sign in to comment.