Skip to content

Commit

Permalink
V4L/DVB (7023): Fix a regresion left by changeset 7e65d6e8f6df
Browse files Browse the repository at this point in the history
Changeset 7e65d6e8f6df removed a very bad hack on mmap(). However, the fixes
weren't considering usermap and overlay memory models. This were breaking
direct reading from /dev/video?, used mostly by mpeg aware drivers.

Thanks to Steven Toth <stoth@linuxtv.org> for reporting the issue and
bissecting it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Mauro Carvalho Chehab committed Jan 25, 2008
1 parent dfd8c04 commit 1f8d300
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions drivers/media/video/videobuf-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,14 @@ int videobuf_iolock(struct videobuf_queue *q, struct videobuf_buffer *vb,
since mmap_mapper() method should be called before _iolock.
On some cases, the mmap_mapper() is called only after scheduling.
*/
wait_event_timeout(vb->done, q->is_mmapped, msecs_to_jiffies(100));
if (!q->is_mmapped) {
printk(KERN_ERR "Error: mmap_mapper() never called!\n");
return -EINVAL;
if (vb->memory == V4L2_MEMORY_MMAP) {
wait_event_timeout(vb->done, q->is_mmapped,
msecs_to_jiffies(100));
if (!q->is_mmapped) {
printk(KERN_ERR
"Error: mmap_mapper() never called!\n");
return -EINVAL;
}
}

return CALL(q, iolock, q, vb, fbuf);
Expand Down

0 comments on commit 1f8d300

Please sign in to comment.