Skip to content

Commit

Permalink
Fix a potential NULL pointer dereference in uli526x_interrupt() in dr…
Browse files Browse the repository at this point in the history
…ivers/net/tulip/uli526x.c

This patch fixes an apparent potential null dereference bug where we
dereference dev before a null check.  This patch simply remvoes the
can't-happen test for a null pointer.

Signed-off-by: Micah Gruber <micah.gruber@gmail.com>
Cc: Grant Grundler <grundler@parisc-linux.org>
Acked-by: Jeff Garzik <jeff@garzik.org>
Acked-by: Kyle McMartin <kyle@mcmartin.ca>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Micah Gruber authored and David S. Miller committed Oct 10, 2007
1 parent 13f7b8c commit 1f8f455
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/net/tulip/uli526x.c
Original file line number Diff line number Diff line change
Expand Up @@ -664,11 +664,6 @@ static irqreturn_t uli526x_interrupt(int irq, void *dev_id)
unsigned long ioaddr = dev->base_addr;
unsigned long flags;

if (!dev) {
ULI526X_DBUG(1, "uli526x_interrupt() without DEVICE arg", 0);
return IRQ_NONE;
}

spin_lock_irqsave(&db->lock, flags);
outl(0, ioaddr + DCR7);

Expand Down

0 comments on commit 1f8f455

Please sign in to comment.