Skip to content

Commit

Permalink
[SCSI] add execute_in_process_context() API
Browse files Browse the repository at this point in the history
We have several points in the SCSI stack (primarily for our device
functions) where we need to guarantee process context, but (given the
place where the last reference was released) we cannot guarantee this.

This API gets around the issue by executing the function directly if
the caller has process context, but scheduling a workqueue to execute
in process context if the caller doesn't have it.

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
  • Loading branch information
James Bottomley authored and James Bottomley committed Feb 28, 2006
1 parent ba3af0a commit 1fa44ec
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 0 deletions.
6 changes: 6 additions & 0 deletions include/linux/workqueue.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ struct work_struct {
struct timer_list timer;
};

struct execute_work {
struct work_struct work;
};

#define __WORK_INITIALIZER(n, f, d) { \
.entry = { &(n).entry, &(n).entry }, \
.func = (f), \
Expand Down Expand Up @@ -74,6 +78,8 @@ extern void init_workqueues(void);
void cancel_rearming_delayed_work(struct work_struct *work);
void cancel_rearming_delayed_workqueue(struct workqueue_struct *,
struct work_struct *);
int execute_in_process_context(void (*fn)(void *), void *,
struct execute_work *);

/*
* Kill off a pending schedule_delayed_work(). Note that the work callback
Expand Down
29 changes: 29 additions & 0 deletions kernel/workqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include <linux/cpu.h>
#include <linux/notifier.h>
#include <linux/kthread.h>
#include <linux/hardirq.h>

/*
* The per-CPU workqueue (if single thread, we always use the first
Expand Down Expand Up @@ -476,6 +477,34 @@ void cancel_rearming_delayed_work(struct work_struct *work)
}
EXPORT_SYMBOL(cancel_rearming_delayed_work);

/**
* execute_in_process_context - reliably execute the routine with user context
* @fn: the function to execute
* @data: data to pass to the function
* @ew: guaranteed storage for the execute work structure (must
* be available when the work executes)
*
* Executes the function immediately if process context is available,
* otherwise schedules the function for delayed execution.
*
* Returns: 0 - function was executed
* 1 - function was scheduled for execution
*/
int execute_in_process_context(void (*fn)(void *data), void *data,
struct execute_work *ew)
{
if (!in_interrupt()) {
fn(data);
return 0;
}

INIT_WORK(&ew->work, fn, data);
schedule_work(&ew->work);

return 1;
}
EXPORT_SYMBOL_GPL(execute_in_process_context);

int keventd_up(void)
{
return keventd_wq != NULL;
Expand Down

0 comments on commit 1fa44ec

Please sign in to comment.