Skip to content

Commit

Permalink
ipv4: do not ignore route errors
Browse files Browse the repository at this point in the history
	The "ipv4: Inline fib_semantic_match into check_leaf"
change forgets to return the route errors. check_leaf should
return the same results as fib_table_lookup.

Signed-off-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julian Anastasov authored and David S. Miller committed Mar 26, 2011
1 parent 6df59a8 commit 1fbc784
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/ipv4/fib_trie.c
Original file line number Diff line number Diff line change
Expand Up @@ -1365,9 +1365,9 @@ static int check_leaf(struct fib_table *tb, struct trie *t, struct leaf *l,
err = fib_props[fa->fa_type].error;
if (err) {
#ifdef CONFIG_IP_FIB_TRIE_STATS
t->stats.semantic_match_miss++;
t->stats.semantic_match_passed++;
#endif
return 1;
return err;
}
if (fi->fib_flags & RTNH_F_DEAD)
continue;
Expand Down

0 comments on commit 1fbc784

Please sign in to comment.