Skip to content

Commit

Permalink
perf tools: Factorize the event structure definitions in a single file
Browse files Browse the repository at this point in the history
Factorize the multiple definition of the events structures into a
single util/event.h file.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Brice Goglin <Brice.Goglin@inria.fr>
  • Loading branch information
Frederic Weisbecker committed Aug 12, 2009
1 parent cd84c2a commit 1fe2c10
Show file tree
Hide file tree
Showing 6 changed files with 56 additions and 125 deletions.
34 changes: 0 additions & 34 deletions tools/perf/builtin-annotate.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,40 +44,6 @@ static int print_line;
static unsigned long page_size;
static unsigned long mmap_window = 32;

struct ip_event {
struct perf_event_header header;
u64 ip;
u32 pid, tid;
};

struct mmap_event {
struct perf_event_header header;
u32 pid, tid;
u64 start;
u64 len;
u64 pgoff;
char filename[PATH_MAX];
};

struct comm_event {
struct perf_event_header header;
u32 pid, tid;
char comm[16];
};

struct fork_event {
struct perf_event_header header;
u32 pid, ppid;
};

typedef union event_union {
struct perf_event_header header;
struct ip_event ip;
struct mmap_event mmap;
struct comm_event comm;
struct fork_event fork;
} event_t;


struct sym_ext {
struct rb_node node;
Expand Down
18 changes: 0 additions & 18 deletions tools/perf/builtin-record.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,24 +59,6 @@ static int file_new = 1;

struct perf_header *header;

struct mmap_event {
struct perf_event_header header;
u32 pid;
u32 tid;
u64 start;
u64 len;
u64 pgoff;
char filename[PATH_MAX];
};

struct comm_event {
struct perf_event_header header;
u32 pid;
u32 tid;
char comm[16];
};


struct mmap_data {
int counter;
void *base;
Expand Down
53 changes: 0 additions & 53 deletions tools/perf/builtin-report.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,59 +75,6 @@ struct callchain_param callchain_param = {

static u64 sample_type;

struct ip_event {
struct perf_event_header header;
u64 ip;
u32 pid, tid;
unsigned char __more_data[];
};

struct mmap_event {
struct perf_event_header header;
u32 pid, tid;
u64 start;
u64 len;
u64 pgoff;
char filename[PATH_MAX];
};

struct comm_event {
struct perf_event_header header;
u32 pid, tid;
char comm[16];
};

struct fork_event {
struct perf_event_header header;
u32 pid, ppid;
u32 tid, ptid;
};

struct lost_event {
struct perf_event_header header;
u64 id;
u64 lost;
};

struct read_event {
struct perf_event_header header;
u32 pid,tid;
u64 value;
u64 time_enabled;
u64 time_running;
u64 id;
};

typedef union event_union {
struct perf_event_header header;
struct ip_event ip;
struct mmap_event mmap;
struct comm_event comm;
struct fork_event fork;
struct lost_event lost;
struct read_event read;
} event_t;

static int repsep_fprintf(FILE *fp, const char *fmt, ...)
{
int n;
Expand Down
20 changes: 0 additions & 20 deletions tools/perf/builtin-top.c
Original file line number Diff line number Diff line change
Expand Up @@ -933,26 +933,6 @@ static void mmap_read_counter(struct mmap_data *md)
last_read = this_read;

for (; old != head;) {
struct ip_event {
struct perf_event_header header;
u64 ip;
u32 pid, target_pid;
};
struct mmap_event {
struct perf_event_header header;
u32 pid, target_pid;
u64 start;
u64 len;
u64 pgoff;
char filename[PATH_MAX];
};

typedef union event_union {
struct perf_event_header header;
struct ip_event ip;
struct mmap_event mmap;
} event_t;

event_t *event = (event_t *)&data[old & md->mask];

event_t event_copy;
Expand Down
54 changes: 54 additions & 0 deletions tools/perf/util/event.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
#include "../perf.h"

struct ip_event {
struct perf_event_header header;
u64 ip;
u32 pid, tid;
unsigned char __more_data[];
};

struct mmap_event {
struct perf_event_header header;
u32 pid, tid;
u64 start;
u64 len;
u64 pgoff;
char filename[PATH_MAX];
};

struct comm_event {
struct perf_event_header header;
u32 pid, tid;
char comm[16];
};

struct fork_event {
struct perf_event_header header;
u32 pid, ppid;
u32 tid, ptid;
};

struct lost_event {
struct perf_event_header header;
u64 id;
u64 lost;
};

struct read_event {
struct perf_event_header header;
u32 pid,tid;
u64 value;
u64 time_enabled;
u64 time_running;
u64 id;
};

typedef union event_union {
struct perf_event_header header;
struct ip_event ip;
struct mmap_event mmap;
struct comm_event comm;
struct fork_event fork;
struct lost_event lost;
struct read_event read;
} event_t;
2 changes: 2 additions & 0 deletions tools/perf/util/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@
#include <inttypes.h>
#include "../../../include/linux/magic.h"

#include "event.h"

#ifndef NO_ICONV
#include <iconv.h>
#endif
Expand Down

0 comments on commit 1fe2c10

Please sign in to comment.