Skip to content

Commit

Permalink
3c503: fix broken IRQ autoprobing
Browse files Browse the repository at this point in the history
Fix broken IRQ autoprobing in 3c503 driver:
 - improper IRQ freeing (does not free IRQs causes WARN)
 - missing break when an working IRQ is found

The driver works with this patch.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Reviewed-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@conan.davemloft.net>
  • Loading branch information
Ondrej Zary authored and David S. Miller committed Jun 13, 2011
1 parent b9cabe5 commit 1ffde03
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/3c503.c
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ el2_open(struct net_device *dev)
outb_p(0x04 << ((*irqp == 9) ? 2 : *irqp), E33G_IDCFR);
outb_p(0x00, E33G_IDCFR);
msleep(1);
free_irq(*irqp, el2_probe_interrupt);
free_irq(*irqp, &seen);
if (!seen)
continue;

Expand All @@ -422,6 +422,7 @@ el2_open(struct net_device *dev)
continue;
if (retval < 0)
goto err_disable;
break;
} while (*++irqp);

if (*irqp == 0) {
Expand Down

0 comments on commit 1ffde03

Please sign in to comment.