Skip to content

Commit

Permalink
HID: picolcd_core: Remove setting hdev->claimed before calling hid_hw…
Browse files Browse the repository at this point in the history
…_start()

Current implementation of hid_hw_start() allows connect_mask to be 0.
Setting hdev->claimed = HID_CLAIMED_INPUT before calling hid_hw_start() is not
necessary. Remove it.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-By: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Axel Lin authored and Jiri Kosina committed Sep 19, 2012
1 parent bb5c32d commit 206e3f1
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/hid/hid-picolcd_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -565,11 +565,7 @@ static int picolcd_probe(struct hid_device *hdev,
goto err_cleanup_data;
}

/* We don't use hidinput but hid_hw_start() fails if nothing is
* claimed. So spoof claimed input. */
hdev->claimed = HID_CLAIMED_INPUT;
error = hid_hw_start(hdev, 0);
hdev->claimed = 0;
if (error) {
hid_err(hdev, "hardware start failed\n");
goto err_cleanup_data;
Expand Down

0 comments on commit 206e3f1

Please sign in to comment.