Skip to content

Commit

Permalink
ide/pci/serverworks.c: Fix corruption/timeouts with MegaIDE
Browse files Browse the repository at this point in the history
It turns out from customer reports to Red Hat and some PCI dumps that the
MegaIDE in RAID mode doesn't provide the drive tuning data that the
serverworks driver expects but sometimes does provide something that
fools the code.

For the RAID class case skip the oem setup and don't trust the BIOS data.
We then tune from scratch and this sorts it out. (This has been confirmed
on an afflicted IBM blade)

[libata serverworks.c never trusts the BIOS in the first place so is
accidentally immune]

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Alan Cox authored and Bartlomiej Zolnierkiewicz committed May 24, 2007
1 parent 6c6a2a8 commit 2074a10
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions drivers/ide/pci/serverworks.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@ static int svwks_tune_chipset (ide_drive_t *drive, u8 xferspeed)
pci_read_config_word(dev, 0x4A, &csb5_pio);
pci_read_config_byte(dev, 0x54, &ultra_enable);

/* If we are in RAID mode (eg AMI MegaIDE) then we can't it
turns out trust the firmware configuration */

if ((dev->class >> 8) != PCI_CLASS_STORAGE_IDE)
goto oem_setup_failed;

/* Per Specified Design by OEM, and ASIC Architect */
if ((dev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
(dev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
Expand Down

0 comments on commit 2074a10

Please sign in to comment.