Skip to content

Commit

Permalink
target: Remove unneeded check in sbc_parse_cdb
Browse files Browse the repository at this point in the history
The check of SCF_SCSI_DATA_CDB seems to be a remnant from before hch's
refactoring of this function. There are no places where that flag is set
that cmd->execute_cmd isn't also set.

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Andy Grover authored and Nicholas Bellinger committed Oct 3, 2014
1 parent 082f58a commit 20959c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/target/target_core_sbc.c
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
}

/* reject any command that we don't have a handler for */
if (!(cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) && !cmd->execute_cmd)
if (!cmd->execute_cmd)
return TCM_UNSUPPORTED_SCSI_OPCODE;

if (cmd->se_cmd_flags & SCF_SCSI_DATA_CDB) {
Expand Down

0 comments on commit 20959c4

Please sign in to comment.