Skip to content

Commit

Permalink
netfilter: Fix format string of nfnetlink_log proc file
Browse files Browse the repository at this point in the history
The printed values are all of type unsigned integer, therefore use
%u instead of %d. Otherwise an user can face negative values.

Signed-off-by: Richard Weinberger <richard@nod.at>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Richard Weinberger authored and David S. Miller committed Apr 13, 2015
1 parent 6b46f7b commit 20a1d16
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/netfilter/nfnetlink_log.c
Original file line number Diff line number Diff line change
Expand Up @@ -1007,7 +1007,7 @@ static int seq_show(struct seq_file *s, void *v)
{
const struct nfulnl_instance *inst = v;

seq_printf(s, "%5d %6d %5d %1d %5d %6d %2d\n",
seq_printf(s, "%5u %6u %5u %1u %5u %6u %2u\n",
inst->group_num,
inst->peer_portid, inst->qlen,
inst->copy_mode, inst->copy_range,
Expand Down

0 comments on commit 20a1d16

Please sign in to comment.