Skip to content

Commit

Permalink
x86: make io_apic not connected pin print complete
Browse files Browse the repository at this point in the history
Normally we will have two segment not connected pin pin0, and pin after
15...

So we need to print out "not connected\n" for previous segment, before
printing out connected pins info...

Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
Yinghai Lu authored and Thomas Gleixner committed Oct 17, 2007
1 parent 382f64a commit 20d225b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
5 changes: 5 additions & 0 deletions arch/x86/kernel/io_apic_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -1296,6 +1296,11 @@ static void __init setup_IO_APIC_irqs(void)
continue;
}

if (!first_notcon) {
apic_printk(APIC_VERBOSE, " not connected.\n");
first_notcon = 1;
}

entry.trigger = irq_trigger(idx);
entry.polarity = irq_polarity(idx);

Expand Down
6 changes: 5 additions & 1 deletion arch/x86/kernel/io_apic_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,10 @@ static void __init setup_IO_APIC_irqs(void)
apic_printk(APIC_VERBOSE, ", %d-%d", mp_ioapics[apic].mpc_apicid, pin);
continue;
}
if (!first_notcon) {
apic_printk(APIC_VERBOSE, " not connected.\n");
first_notcon = 1;
}

irq = pin_2_irq(idx, apic, pin);
add_pin_to_irq(irq, apic, pin);
Expand All @@ -885,7 +889,7 @@ static void __init setup_IO_APIC_irqs(void)
}

if (!first_notcon)
apic_printk(APIC_VERBOSE," not connected.\n");
apic_printk(APIC_VERBOSE, " not connected.\n");
}

/*
Expand Down

0 comments on commit 20d225b

Please sign in to comment.