Skip to content

Commit

Permalink
NFS: Add a client-side function to display NFS file handles
Browse files Browse the repository at this point in the history
For debugging, introduce a simplistic function to print NFS file
handles on the system console.  The main function is hooked into the
dprintk debugging facility, but you can directly call the helper,
_nfs_display_fhandle(), if you want to print a handle unconditionally.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Chuck Lever authored and Trond Myklebust committed Mar 2, 2012
1 parent 31b8e2a commit 20d27e9
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 0 deletions.
45 changes: 45 additions & 0 deletions fs/nfs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -1045,6 +1045,51 @@ struct nfs_fh *nfs_alloc_fhandle(void)
return fh;
}

/**
* _nfs_display_fhandle - display an NFS file handle on the console
*
* @fh: file handle to display
* @caption: display caption
*
* For debugging only.
*/
#ifdef RPC_DEBUG
void _nfs_display_fhandle(const struct nfs_fh *fh, const char *caption)
{
unsigned short i;

if (fh->size == 0 || fh == NULL) {
printk(KERN_DEFAULT "%s at %p is empty\n", caption, fh);
return;
}

printk(KERN_DEFAULT "%s at %p is %u bytes:\n", caption, fh, fh->size);
for (i = 0; i < fh->size; i += 16) {
__be32 *pos = (__be32 *)&fh->data[i];

switch ((fh->size - i - 1) >> 2) {
case 0:
printk(KERN_DEFAULT " %08x\n",
be32_to_cpup(pos));
break;
case 1:
printk(KERN_DEFAULT " %08x %08x\n",
be32_to_cpup(pos), be32_to_cpup(pos + 1));
break;
case 2:
printk(KERN_DEFAULT " %08x %08x %08x\n",
be32_to_cpup(pos), be32_to_cpup(pos + 1),
be32_to_cpup(pos + 2));
break;
default:
printk(KERN_DEFAULT " %08x %08x %08x %08x\n",
be32_to_cpup(pos), be32_to_cpup(pos + 1),
be32_to_cpup(pos + 2), be32_to_cpup(pos + 3));
}
}
}
#endif

/**
* nfs_inode_attrs_need_update - check if the inode attributes need updating
* @inode - pointer to inode
Expand Down
14 changes: 14 additions & 0 deletions include/linux/nfs_fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,20 @@ static inline void nfs_free_fhandle(const struct nfs_fh *fh)
kfree(fh);
}

#ifdef RPC_DEBUG
extern void _nfs_display_fhandle(const struct nfs_fh *fh, const char *caption);
#define nfs_display_fhandle(fh, caption) \
do { \
if (unlikely(nfs_debug & NFSDBG_FACILITY)) \
_nfs_display_fhandle(fh, caption); \
} while (0)
#else
static inline void nfs_display_fhandle(const struct nfs_fh *fh,
const char *caption)
{
}
#endif

/*
* linux/fs/nfs/nfsroot.c
*/
Expand Down

0 comments on commit 20d27e9

Please sign in to comment.