Skip to content

Commit

Permalink
drivers/misc/lkdtm.c: cleanups
Browse files Browse the repository at this point in the history
- make needlessly global functions static
- make lkdtm_module_{init,exit}() as __{init,exit}

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Cc: Ankita Garg <ankita@in.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Adrian Bunk authored and Linus Torvalds committed Feb 6, 2008
1 parent 2646437 commit 2118116
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions drivers/misc/lkdtm.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,51 +129,53 @@ module_param(cpoint_count, int, 0644);
MODULE_PARM_DESC(cpoint_count, " Crash Point Count, number of times the "\
"crash point is to be hit to trigger action");

unsigned int jp_do_irq(unsigned int irq)
static unsigned int jp_do_irq(unsigned int irq)
{
lkdtm_handler();
jprobe_return();
return 0;
}

irqreturn_t jp_handle_irq_event(unsigned int irq, struct irqaction *action)
static irqreturn_t jp_handle_irq_event(unsigned int irq,
struct irqaction *action)
{
lkdtm_handler();
jprobe_return();
return 0;
}

void jp_tasklet_action(struct softirq_action *a)
static void jp_tasklet_action(struct softirq_action *a)
{
lkdtm_handler();
jprobe_return();
}

void jp_ll_rw_block(int rw, int nr, struct buffer_head *bhs[])
static void jp_ll_rw_block(int rw, int nr, struct buffer_head *bhs[])
{
lkdtm_handler();
jprobe_return();
}

struct scan_control;

unsigned long jp_shrink_inactive_list(unsigned long max_scan,
struct zone *zone, struct scan_control *sc)
static unsigned long jp_shrink_inactive_list(unsigned long max_scan,
struct zone *zone,
struct scan_control *sc)
{
lkdtm_handler();
jprobe_return();
return 0;
}

int jp_hrtimer_start(struct hrtimer *timer, ktime_t tim,
const enum hrtimer_mode mode)
static int jp_hrtimer_start(struct hrtimer *timer, ktime_t tim,
const enum hrtimer_mode mode)
{
lkdtm_handler();
jprobe_return();
return 0;
}

int jp_scsi_dispatch_cmd(struct scsi_cmnd *cmd)
static int jp_scsi_dispatch_cmd(struct scsi_cmnd *cmd)
{
lkdtm_handler();
jprobe_return();
Expand Down Expand Up @@ -270,7 +272,7 @@ void lkdtm_handler(void)
}
}

int lkdtm_module_init(void)
static int __init lkdtm_module_init(void)
{
int ret;

Expand Down Expand Up @@ -331,7 +333,7 @@ int lkdtm_module_init(void)
return 0;
}

void lkdtm_module_exit(void)
static void __exit lkdtm_module_exit(void)
{
unregister_jprobe(&lkdtm);
printk(KERN_INFO "lkdtm : Crash point unregistered\n");
Expand Down

0 comments on commit 2118116

Please sign in to comment.