Skip to content

Commit

Permalink
net: irda: use seq_list_foo() helpers
Browse files Browse the repository at this point in the history
Simplify seq_file code.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Li Zefan authored and David S. Miller committed Feb 10, 2010
1 parent 4f13420 commit 216437e
Showing 1 changed file with 4 additions and 24 deletions.
28 changes: 4 additions & 24 deletions net/irda/irlan/irlan_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -1128,34 +1128,14 @@ int irlan_extract_param(__u8 *buf, char *name, char *value, __u16 *len)
*/
static void *irlan_seq_start(struct seq_file *seq, loff_t *pos)
{
int i = 1;
struct irlan_cb *self;

rcu_read_lock();
if (*pos == 0)
return SEQ_START_TOKEN;

list_for_each_entry(self, &irlans, dev_list) {
if (*pos == i)
return self;
++i;
}
return NULL;
return seq_list_start_head(&irlans, *pos);
}

/* Return entry after v, and increment pos */
static void *irlan_seq_next(struct seq_file *seq, void *v, loff_t *pos)
{
struct list_head *nxt;

++*pos;
if (v == SEQ_START_TOKEN)
nxt = irlans.next;
else
nxt = ((struct irlan_cb *)v)->dev_list.next;

return (nxt == &irlans) ? NULL
: list_entry(nxt, struct irlan_cb, dev_list);
return seq_list_next(v, &irlans, pos);
}

/* End of reading /proc file */
Expand All @@ -1170,10 +1150,10 @@ static void irlan_seq_stop(struct seq_file *seq, void *v)
*/
static int irlan_seq_show(struct seq_file *seq, void *v)
{
if (v == SEQ_START_TOKEN)
if (v == &irlans)
seq_puts(seq, "IrLAN instances:\n");
else {
struct irlan_cb *self = v;
struct irlan_cb *self = list_entry(v, struct irlan_cb, dev_list);

IRDA_ASSERT(self != NULL, return -1;);
IRDA_ASSERT(self->magic == IRLAN_MAGIC, return -1;);
Expand Down

0 comments on commit 216437e

Please sign in to comment.