Skip to content

Commit

Permalink
[IB/ipoib]: Fix unsigned comparisons to handle wraparound
Browse files Browse the repository at this point in the history
Fix handling of tx_head/tx_tail comparisons to handle wraparound.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Roland Dreier committed Jul 27, 2005
1 parent abdf119 commit 2181858
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/infiniband/ulp/ipoib/ipoib_ib.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ void ipoib_free_ah(struct kref *kref)

unsigned long flags;

if (ah->last_send <= priv->tx_tail) {
if ((int) priv->tx_tail - (int) ah->last_send >= 0) {
ipoib_dbg(priv, "Freeing ah %p\n", ah->ah);
ib_destroy_ah(ah->ah);
kfree(ah);
Expand Down Expand Up @@ -355,7 +355,7 @@ static void __ipoib_reap_ah(struct net_device *dev)

spin_lock_irq(&priv->lock);
list_for_each_entry_safe(ah, tah, &priv->dead_ahs, list)
if (ah->last_send <= priv->tx_tail) {
if ((int) priv->tx_tail - (int) ah->last_send >= 0) {
list_del(&ah->list);
list_add_tail(&ah->list, &remove_list);
}
Expand Down Expand Up @@ -486,7 +486,7 @@ int ipoib_ib_dev_stop(struct net_device *dev)
* assume the HW is wedged and just free up
* all our pending work requests.
*/
while (priv->tx_tail < priv->tx_head) {
while ((int) priv->tx_tail - (int) priv->tx_head < 0) {
tx_req = &priv->tx_ring[priv->tx_tail &
(IPOIB_TX_RING_SIZE - 1)];
dma_unmap_single(priv->ca->dma_device,
Expand Down

0 comments on commit 2181858

Please sign in to comment.