Skip to content

Commit

Permalink
OMAP2: serial.c: Fix number of uarts in early_init
Browse files Browse the repository at this point in the history
The omap_serial_early_init prints the following errors:

Could not get uart4_ick
Could not get uart4_fck

because all the uarts available in omap_uart[] will be initialized.
Only omap4430 and omap3630 have 4 uarts at the moment.
This patch reduces the number of uarts when cpu is not omap4430 or
omap3630.

Signed-off-by: Thomas Weber <weber@corscience.de>
Signed-off-by: Tony Lindgren <tony@atomide.com>
  • Loading branch information
Thomas Weber authored and Tony Lindgren committed Mar 11, 2010
1 parent 9e542f3 commit 21b9034
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions arch/arm/mach-omap2/serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -644,16 +644,21 @@ static void serial_out_override(struct uart_port *up, int offset, int value)
}
void __init omap_serial_early_init(void)
{
int i;
int i, nr_ports;
char name[16];

if (!(cpu_is_omap3630() || cpu_is_omap4430()))
nr_ports = 3;
else
nr_ports = ARRAY_SIZE(omap_uart);

/*
* Make sure the serial ports are muxed on at this point.
* You have to mux them off in device drivers later on
* if not needed.
*/

for (i = 0; i < ARRAY_SIZE(omap_uart); i++) {
for (i = 0; i < nr_ports; i++) {
struct omap_uart_state *uart = &omap_uart[i];
struct platform_device *pdev = &uart->pdev;
struct device *dev = &pdev->dev;
Expand All @@ -669,17 +674,17 @@ void __init omap_serial_early_init(void)
continue;
}

sprintf(name, "uart%d_ick", i+1);
sprintf(name, "uart%d_ick", i + 1);
uart->ick = clk_get(NULL, name);
if (IS_ERR(uart->ick)) {
printk(KERN_ERR "Could not get uart%d_ick\n", i+1);
printk(KERN_ERR "Could not get uart%d_ick\n", i + 1);
uart->ick = NULL;
}

sprintf(name, "uart%d_fck", i+1);
uart->fck = clk_get(NULL, name);
if (IS_ERR(uart->fck)) {
printk(KERN_ERR "Could not get uart%d_fck\n", i+1);
printk(KERN_ERR "Could not get uart%d_fck\n", i + 1);
uart->fck = NULL;
}

Expand Down

0 comments on commit 21b9034

Please sign in to comment.