Skip to content

Commit

Permalink
ixgbe: convert to use simple_open()
Browse files Browse the repository at this point in the history
This removes an open coded simple_open() function and
replaces file operations references to the function
with simple_open() instead.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
  • Loading branch information
Wei Yongjun authored and Jeff Kirsher committed Nov 22, 2012
1 parent 8ad88e3 commit 21cc57f
Showing 1 changed file with 2 additions and 30 deletions.
32 changes: 2 additions & 30 deletions drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,6 @@ static struct dentry *ixgbe_dbg_root;

static char ixgbe_dbg_reg_ops_buf[256] = "";

/**
* ixgbe_dbg_reg_ops_open - prep the debugfs pokee data item when opened
* @inode: inode that was opened
* @filp: file info
*
* Stash the adapter pointer hiding in the inode into the file pointer where
* we can find it later in the read and write calls
**/
static int ixgbe_dbg_reg_ops_open(struct inode *inode, struct file *filp)
{
filp->private_data = inode->i_private;
return 0;
}

/**
* ixgbe_dbg_reg_ops_read - read for reg_ops datum
* @filp: the opened file
Expand Down Expand Up @@ -142,27 +128,13 @@ static ssize_t ixgbe_dbg_reg_ops_write(struct file *filp,

static const struct file_operations ixgbe_dbg_reg_ops_fops = {
.owner = THIS_MODULE,
.open = ixgbe_dbg_reg_ops_open,
.open = simple_open,
.read = ixgbe_dbg_reg_ops_read,
.write = ixgbe_dbg_reg_ops_write,
};

static char ixgbe_dbg_netdev_ops_buf[256] = "";

/**
* ixgbe_dbg_netdev_ops_open - prep the debugfs netdev_ops data item
* @inode: inode that was opened
* @filp: file info
*
* Stash the adapter pointer hiding in the inode into the file pointer
* where we can find it later in the read and write calls
**/
static int ixgbe_dbg_netdev_ops_open(struct inode *inode, struct file *filp)
{
filp->private_data = inode->i_private;
return 0;
}

/**
* ixgbe_dbg_netdev_ops_read - read for netdev_ops datum
* @filp: the opened file
Expand Down Expand Up @@ -238,7 +210,7 @@ static ssize_t ixgbe_dbg_netdev_ops_write(struct file *filp,

static const struct file_operations ixgbe_dbg_netdev_ops_fops = {
.owner = THIS_MODULE,
.open = ixgbe_dbg_netdev_ops_open,
.open = simple_open,
.read = ixgbe_dbg_netdev_ops_read,
.write = ixgbe_dbg_netdev_ops_write,
};
Expand Down

0 comments on commit 21cc57f

Please sign in to comment.