Skip to content

Commit

Permalink
OMAPDSS: MANAGER/APPLY: Add runtime_pm protection around wait_for_go/…
Browse files Browse the repository at this point in the history
…vsync functions

If DSS suspends within the functions dss_mgr_wait_for_go(),
dss_mgr_wait_for_go_ovl() or dss_mgr_wait_for_vsync(). It may lose it's clock
and lead to a register access failure.

Request runtime_pm around these functions.

[archit@ti.com: Moved runtime_pm calls to wait_for_go/vsync functions rather
then calling them from omap_dispc_wait_for_irq_interruptible_timeout()]

Signed-off-by: Archit Taneja <archit@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
  • Loading branch information
Lajos Molnar authored and Tomi Valkeinen committed Mar 6, 2012
1 parent c0c1cfc commit 21e56f7
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 1 deletion.
12 changes: 12 additions & 0 deletions drivers/video/omap2/dss/apply.c
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,10 @@ int dss_mgr_wait_for_go(struct omap_overlay_manager *mgr)
if (mgr_manual_update(mgr))
return 0;

r = dispc_runtime_get();
if (r)
return r;

irq = dispc_mgr_get_vsync_irq(mgr->id);

mp = get_mgr_priv(mgr);
Expand Down Expand Up @@ -431,6 +435,8 @@ int dss_mgr_wait_for_go(struct omap_overlay_manager *mgr)
}
}

dispc_runtime_put();

return r;
}

Expand All @@ -454,6 +460,10 @@ int dss_mgr_wait_for_go_ovl(struct omap_overlay *ovl)
if (ovl_manual_update(ovl))
return 0;

r = dispc_runtime_get();
if (r)
return r;

irq = dispc_mgr_get_vsync_irq(ovl->manager->id);

op = get_ovl_priv(ovl);
Expand Down Expand Up @@ -494,6 +504,8 @@ int dss_mgr_wait_for_go_ovl(struct omap_overlay *ovl)
}
}

dispc_runtime_put();

return r;
}

Expand Down
12 changes: 11 additions & 1 deletion drivers/video/omap2/dss/manager.c
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,11 @@ static int dss_mgr_wait_for_vsync(struct omap_overlay_manager *mgr)
{
unsigned long timeout = msecs_to_jiffies(500);
u32 irq;
int r;

r = dispc_runtime_get();
if (r)
return r;

if (mgr->device->type == OMAP_DISPLAY_TYPE_VENC) {
irq = DISPC_IRQ_EVSYNC_ODD;
Expand All @@ -505,7 +510,12 @@ static int dss_mgr_wait_for_vsync(struct omap_overlay_manager *mgr)
else
irq = DISPC_IRQ_VSYNC2;
}
return omap_dispc_wait_for_irq_interruptible_timeout(irq, timeout);

r = omap_dispc_wait_for_irq_interruptible_timeout(irq, timeout);

dispc_runtime_put();

return r;
}

int dss_init_overlay_managers(struct platform_device *pdev)
Expand Down

0 comments on commit 21e56f7

Please sign in to comment.