Skip to content

Commit

Permalink
Input: uinput - semaphore to mutex conversion
Browse files Browse the repository at this point in the history
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Dmitry Torokhov committed Feb 19, 2006
1 parent 72ba9f0 commit 221979a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
14 changes: 7 additions & 7 deletions drivers/input/misc/uinput.c
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ static int uinput_open(struct inode *inode, struct file *file)
if (!newdev)
return -ENOMEM;

init_MUTEX(&newdev->sem);
mutex_init(&newdev->mutex);
spin_lock_init(&newdev->requests_lock);
init_waitqueue_head(&newdev->requests_waitq);
init_waitqueue_head(&newdev->waitq);
Expand Down Expand Up @@ -340,15 +340,15 @@ static ssize_t uinput_write(struct file *file, const char __user *buffer, size_t
struct uinput_device *udev = file->private_data;
int retval;

retval = down_interruptible(&udev->sem);
retval = mutex_lock_interruptible(&udev->mutex);
if (retval)
return retval;

retval = udev->state == UIST_CREATED ?
uinput_inject_event(udev, buffer, count) :
uinput_setup_device(udev, buffer, count);

up(&udev->sem);
mutex_unlock(&udev->mutex);

return retval;
}
Expand All @@ -369,7 +369,7 @@ static ssize_t uinput_read(struct file *file, char __user *buffer, size_t count,
if (retval)
return retval;

retval = down_interruptible(&udev->sem);
retval = mutex_lock_interruptible(&udev->mutex);
if (retval)
return retval;

Expand All @@ -388,7 +388,7 @@ static ssize_t uinput_read(struct file *file, char __user *buffer, size_t count,
}

out:
up(&udev->sem);
mutex_unlock(&udev->mutex);

return retval;
}
Expand Down Expand Up @@ -439,7 +439,7 @@ static long uinput_ioctl(struct file *file, unsigned int cmd, unsigned long arg)

udev = file->private_data;

retval = down_interruptible(&udev->sem);
retval = mutex_lock_interruptible(&udev->mutex);
if (retval)
return retval;

Expand Down Expand Up @@ -589,7 +589,7 @@ static long uinput_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
}

out:
up(&udev->sem);
mutex_unlock(&udev->mutex);
return retval;
}

Expand Down
4 changes: 2 additions & 2 deletions include/linux/uinput.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
* Author: Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
*
*
* Changes/Revisions:
* 0.2 16/10/2004 (Micah Dowty <micah@navi.cx>)
* - added force feedback support
Expand Down Expand Up @@ -51,7 +51,7 @@ struct uinput_request {

struct uinput_device {
struct input_dev *dev;
struct semaphore sem;
struct mutex mutex;
enum uinput_state state;
wait_queue_head_t waitq;
unsigned char ready;
Expand Down

0 comments on commit 221979a

Please sign in to comment.