Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 191092
b: refs/heads/master
c: d06d92b
h: refs/heads/master
v: v3
  • Loading branch information
Arnaldo Carvalho de Melo authored and Ingo Molnar committed Mar 15, 2010
1 parent e409f3a commit 222c72e
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 2 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: b0a9ab62ab96e258a0ddd81d7fe2719c3db36006
refs/heads/master: d06d92b7c9b99ea52bdaeb13f544675529891b8a
10 changes: 10 additions & 0 deletions trunk/tools/perf/builtin-annotate.c
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,16 @@ static void annotate_sym(struct hist_entry *he)
if (!filename)
return;

if (dso->origin == DSO__ORIG_KERNEL) {
if (dso->annotate_warned)
return;
dso->annotate_warned = 1;
pr_err("Can't annotate %s: No vmlinux file was found in the "
"path:\n", sym->name);
vmlinux_path__fprintf(stderr);
return;
}

pr_debug("%s: filename=%s, sym=%s, start=%#Lx, end=%#Lx\n", __func__,
filename, sym->name, map->unmap_ip(map, sym->start),
map->unmap_ip(map, sym->end));
Expand Down
2 changes: 1 addition & 1 deletion trunk/tools/perf/util/newt.c
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ static void hist_entry__annotate_browser(struct hist_entry *self)
if (self->sym == NULL)
return;

if (asprintf(&str, "perf annotate %s | expand", self->sym->name) < 0)
if (asprintf(&str, "perf annotate %s 2>&1 | expand", self->sym->name) < 0)
return;

fp = popen(str, "r");
Expand Down
1 change: 1 addition & 0 deletions trunk/tools/perf/util/symbol.h
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ struct dso {
u8 has_build_id:1;
u8 kernel:1;
u8 hit:1;
u8 annotate_warned:1;
unsigned char origin;
u8 sorted_by_name;
u8 loaded;
Expand Down

0 comments on commit 222c72e

Please sign in to comment.