Skip to content

Commit

Permalink
staging: xgifb: eliminate pVBInfo->ScreenOffset
Browse files Browse the repository at this point in the history
Access XGI330_ScreenOffset directly and make it const.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Aaro Koskinen authored and Greg Kroah-Hartman committed Nov 13, 2012
1 parent acfe093 commit 224114c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
5 changes: 2 additions & 3 deletions drivers/staging/xgifb/vb_setmode.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ static const unsigned short XGINew_VGA_DAC[] = {
void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo)
{
pVBInfo->MCLKData = XGI340New_MCLKData;
pVBInfo->ScreenOffset = XGI330_ScreenOffset;
pVBInfo->StResInfo = XGI330_StResInfo;
pVBInfo->ModeResInfo = XGI330_ModeResInfo;

Expand Down Expand Up @@ -806,7 +805,7 @@ static void XGI_SetCRT1Offset(unsigned short ModeNo,
/* GetOffset */
temp = XGI330_EModeIDTable[ModeIdIndex].Ext_ModeInfo;
temp = temp >> 8;
temp = pVBInfo->ScreenOffset[temp];
temp = XGI330_ScreenOffset[temp];

temp2 = XGI330_RefIndex[RefreshRateTableIndex].Ext_InfoFlag;
temp2 &= InterlaceMode;
Expand Down Expand Up @@ -2977,7 +2976,7 @@ static unsigned short XGI_GetOffset(unsigned short ModeNo,

index = (modeinfo >> 8) & 0xFF;

temp = pVBInfo->ScreenOffset[index];
temp = XGI330_ScreenOffset[index];

if (infoflag & InterlaceMode)
temp = temp << 1;
Expand Down
1 change: 0 additions & 1 deletion drivers/staging/xgifb/vb_struct.h
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ struct vb_device_info {
unsigned char SR25;
struct SiS_MCLKData *MCLKData;

unsigned char *ScreenOffset;
unsigned char *pXGINew_DRAMTypeDefinition;
unsigned char XGINew_CR97;

Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/xgifb/vb_table.h
Original file line number Diff line number Diff line change
Expand Up @@ -2117,7 +2117,7 @@ const struct XGI_Ext2Struct XGI330_RefIndex[] = {
0x30, 0x47, 0x37, 1024, 768},/* 48 1024x768x160Hz */
};

static unsigned char XGI330_ScreenOffset[] = {
static const unsigned char XGI330_ScreenOffset[] = {
0x14, 0x19, 0x20, 0x28, 0x32, 0x40,
0x50, 0x64, 0x78, 0x80, 0x2d, 0x35,
0x57, 0x48
Expand Down

0 comments on commit 224114c

Please sign in to comment.