Skip to content

Commit

Permalink
[PATCH] USBATM: use dev_kfree_skb_any rather than dev_kfree_skb
Browse files Browse the repository at this point in the history
In one spot (usbatm_cancel_send) we were calling dev_kfree_skb with irqs
disabled.  This mistake is just too easy to make, so systematically use
dev_kfree_skb_any rather than dev_kfree_skb.

Signed-off-by: Duncan Sands <baldrick@free.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Duncan Sands authored and Greg Kroah-Hartman committed Feb 1, 2006
1 parent 72ef8ab commit 227d776
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/usb/atm/usbatm.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
#include <linux/netdevice.h>
#include <linux/proc_fs.h>
#include <linux/sched.h>
#include <linux/signal.h>
Expand Down Expand Up @@ -199,7 +200,7 @@ static inline void usbatm_pop(struct atm_vcc *vcc, struct sk_buff *skb)
if (vcc->pop)
vcc->pop(vcc, skb);
else
dev_kfree_skb(skb);
dev_kfree_skb_any(skb);
}


Expand Down Expand Up @@ -397,7 +398,7 @@ static void usbatm_extract_cells(struct usbatm_data *instance,
if (!atm_charge(vcc, skb->truesize)) {
atm_rldbg(instance, "%s: failed atm_charge (skb->truesize: %u)!\n",
__func__, skb->truesize);
dev_kfree_skb(skb);
dev_kfree_skb_any(skb);
goto out; /* atm_charge increments rx_drop */
}

Expand Down

0 comments on commit 227d776

Please sign in to comment.