Skip to content

Commit

Permalink
rxrpc: Replace get_seconds with ktime_get_seconds
Browse files Browse the repository at this point in the history
Replace time_t type and get_seconds function which are not y2038 safe
on 32-bit systems. Function ktime_get_seconds use monotonic instead of
real time and therefore will not cause overflow.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ksenija Stanojevic authored and David S. Miller committed Sep 21, 2015
1 parent 62e3b1d commit 22a3f9a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions net/rxrpc/ar-connection.c
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ void rxrpc_put_connection(struct rxrpc_connection *conn)

ASSERTCMP(atomic_read(&conn->usage), >, 0);

conn->put_time = get_seconds();
conn->put_time = ktime_get_seconds();
if (atomic_dec_and_test(&conn->usage)) {
_debug("zombie");
rxrpc_queue_delayed_work(&rxrpc_connection_reap, 0);
Expand Down Expand Up @@ -852,7 +852,7 @@ static void rxrpc_connection_reaper(struct work_struct *work)

_enter("");

now = get_seconds();
now = ktime_get_seconds();
earliest = ULONG_MAX;

write_lock_bh(&rxrpc_connection_lock);
Expand Down
4 changes: 2 additions & 2 deletions net/rxrpc/ar-internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ struct rxrpc_transport {
struct rb_root server_conns; /* server connections on this transport */
struct list_head link; /* link in master session list */
struct sk_buff_head error_queue; /* error packets awaiting processing */
time_t put_time; /* time at which to reap */
unsigned long put_time; /* time at which to reap */
spinlock_t client_lock; /* client connection allocation lock */
rwlock_t conn_lock; /* lock for active/dead connections */
atomic_t usage;
Expand Down Expand Up @@ -256,7 +256,7 @@ struct rxrpc_connection {
struct rxrpc_crypt csum_iv; /* packet checksum base */
unsigned long events;
#define RXRPC_CONN_CHALLENGE 0 /* send challenge packet */
time_t put_time; /* time at which to reap */
unsigned long put_time; /* time at which to reap */
rwlock_t lock; /* access lock */
spinlock_t state_lock; /* state-change lock */
atomic_t usage;
Expand Down
4 changes: 2 additions & 2 deletions net/rxrpc/ar-transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ void rxrpc_put_transport(struct rxrpc_transport *trans)

ASSERTCMP(atomic_read(&trans->usage), >, 0);

trans->put_time = get_seconds();
trans->put_time = ktime_get_seconds();
if (unlikely(atomic_dec_and_test(&trans->usage))) {
_debug("zombie");
/* let the reaper determine the timeout to avoid a race with
Expand Down Expand Up @@ -226,7 +226,7 @@ static void rxrpc_transport_reaper(struct work_struct *work)

_enter("");

now = get_seconds();
now = ktime_get_seconds();
earliest = ULONG_MAX;

/* extract all the transports that have been dead too long */
Expand Down

0 comments on commit 22a3f9a

Please sign in to comment.