Skip to content

Commit

Permalink
BKL: Remove BKL from JFS
Browse files Browse the repository at this point in the history
The BKL is only used in put_super, fill_super and remount_fs that are all
three protected by the superblocks s_umount rw_semaphore. Therefore it is
safe to remove the BKL entirely.

Signed-off-by: Jan Blunck <jblunck@infradead.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
  • Loading branch information
Jan Blunck authored and Arnd Bergmann committed Oct 4, 2010
1 parent 8526fb3 commit 22b26db
Showing 1 changed file with 7 additions and 28 deletions.
35 changes: 7 additions & 28 deletions fs/jfs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include <linux/slab.h>
#include <asm/uaccess.h>
#include <linux/seq_file.h>
#include <linux/smp_lock.h>

#include "jfs_incore.h"
#include "jfs_filsys.h"
Expand Down Expand Up @@ -176,8 +175,6 @@ static void jfs_put_super(struct super_block *sb)

dquot_disable(sb, -1, DQUOT_USAGE_ENABLED | DQUOT_LIMITS_ENABLED);

lock_kernel();

rc = jfs_umount(sb);
if (rc)
jfs_err("jfs_umount failed with return code %d", rc);
Expand All @@ -188,8 +185,6 @@ static void jfs_put_super(struct super_block *sb)
iput(sbi->direct_inode);

kfree(sbi);

unlock_kernel();
}

enum {
Expand Down Expand Up @@ -369,19 +364,16 @@ static int jfs_remount(struct super_block *sb, int *flags, char *data)
if (!parse_options(data, sb, &newLVSize, &flag)) {
return -EINVAL;
}
lock_kernel();

if (newLVSize) {
if (sb->s_flags & MS_RDONLY) {
printk(KERN_ERR
"JFS: resize requires volume to be mounted read-write\n");
unlock_kernel();
return -EROFS;
}
rc = jfs_extendfs(sb, newLVSize, 0);
if (rc) {
unlock_kernel();
if (rc)
return rc;
}
}

if ((sb->s_flags & MS_RDONLY) && !(*flags & MS_RDONLY)) {
Expand All @@ -397,36 +389,30 @@ static int jfs_remount(struct super_block *sb, int *flags, char *data)
/* mark the fs r/w for quota activity */
sb->s_flags &= ~MS_RDONLY;

unlock_kernel();
dquot_resume(sb, -1);
return ret;
}
if ((!(sb->s_flags & MS_RDONLY)) && (*flags & MS_RDONLY)) {
rc = dquot_suspend(sb, -1);
if (rc < 0) {
unlock_kernel();
return rc;
}
rc = jfs_umount_rw(sb);
JFS_SBI(sb)->flag = flag;
unlock_kernel();
return rc;
}
if ((JFS_SBI(sb)->flag & JFS_NOINTEGRITY) != (flag & JFS_NOINTEGRITY))
if (!(sb->s_flags & MS_RDONLY)) {
rc = jfs_umount_rw(sb);
if (rc) {
unlock_kernel();
if (rc)
return rc;
}

JFS_SBI(sb)->flag = flag;
ret = jfs_mount_rw(sb, 1);
unlock_kernel();
return ret;
}
JFS_SBI(sb)->flag = flag;

unlock_kernel();
return 0;
}

Expand All @@ -438,20 +424,15 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
s64 newLVSize = 0;
int flag, ret = -EINVAL;

lock_kernel();

jfs_info("In jfs_read_super: s_flags=0x%lx", sb->s_flags);

if (!new_valid_dev(sb->s_bdev->bd_dev)) {
unlock_kernel();
if (!new_valid_dev(sb->s_bdev->bd_dev))
return -EOVERFLOW;
}

sbi = kzalloc(sizeof (struct jfs_sb_info), GFP_KERNEL);
if (!sbi) {
unlock_kernel();
if (!sbi)
return -ENOMEM;
}

sb->s_fs_info = sbi;
sbi->sb = sb;
sbi->uid = sbi->gid = sbi->umask = -1;
Expand Down Expand Up @@ -548,7 +529,6 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
sb->s_maxbytes = min(((u64) PAGE_CACHE_SIZE << 32) - 1, (u64)sb->s_maxbytes);
#endif
sb->s_time_gran = 1;
unlock_kernel();
return 0;

out_no_root:
Expand All @@ -571,7 +551,6 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
unload_nls(sbi->nls_tab);
out_kfree:
kfree(sbi);
unlock_kernel();
return ret;
}

Expand Down

0 comments on commit 22b26db

Please sign in to comment.