Skip to content

Commit

Permalink
Staging: comedi: clean up sparse issues in proc.c
Browse files Browse the repository at this point in the history
The whole file should be converted to use seqfile, if it's even
still needed.  Or move to debugfs.

Anyway, I fixed up the minor issues here.

Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed May 11, 2010
1 parent 09372df commit 22d1142
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions drivers/staging/comedi/proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,11 @@
#include "comedidev.h"
#include "comedi_fops.h"
#include <linux/proc_fs.h>
/* #include <linux/string.h> */
#include <linux/string.h>

int comedi_read_procmem(char *buf, char **start, off_t offset, int len,
int *eof, void *data)
#ifdef CONFIG_PROC_FS
static int comedi_read(char *buf, char **start, off_t offset, int len,
int *eof, void *data)
{
int i;
int devices_q = 0;
Expand Down Expand Up @@ -82,18 +83,17 @@ int comedi_read_procmem(char *buf, char **start, off_t offset, int len,
return l;
}

#ifdef CONFIG_PROC_FS
void comedi_proc_init(void)
{
struct proc_dir_entry *comedi_proc;

comedi_proc = create_proc_entry("comedi", S_IFREG | S_IRUGO, 0);
comedi_proc = create_proc_entry("comedi", S_IFREG | S_IRUGO, NULL);
if (comedi_proc)
comedi_proc->read_proc = comedi_read_procmem;
comedi_proc->read_proc = comedi_read;
}

void comedi_proc_cleanup(void)
{
remove_proc_entry("comedi", 0);
remove_proc_entry("comedi", NULL);
}
#endif

0 comments on commit 22d1142

Please sign in to comment.