Skip to content

Commit

Permalink
configfs: Release memory in configfs_example.
Browse files Browse the repository at this point in the history
The configfs_example module was missing a ->release().

Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>
  • Loading branch information
Joel Becker authored and Mark Fasheh committed Jun 29, 2006
1 parent 8d231c1 commit 22dd0e8
Showing 1 changed file with 15 additions and 4 deletions.
19 changes: 15 additions & 4 deletions Documentation/filesystems/configfs/configfs_example.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,15 @@ static struct config_item_type simple_child_type = {
};


struct simple_children {
struct config_group group;
};

static inline struct simple_children *to_simple_children(struct config_item *item)
{
return item ? container_of(to_config_group(item), struct simple_children, group) : NULL;
}

static struct config_item *simple_children_make_item(struct config_group *group, const char *name)
{
struct simple_child *simple_child;
Expand Down Expand Up @@ -304,7 +313,13 @@ static ssize_t simple_children_attr_show(struct config_item *item,
"items have only one attribute that is readable and writeable.\n");
}

static void simple_children_release(struct config_item *item)
{
kfree(to_simple_children(item));
}

static struct configfs_item_operations simple_children_item_ops = {
.release = simple_children_release,
.show_attribute = simple_children_attr_show,
};

Expand Down Expand Up @@ -345,10 +360,6 @@ static struct configfs_subsystem simple_children_subsys = {
* children of its own.
*/

struct simple_children {
struct config_group group;
};

static struct config_group *group_children_make_group(struct config_group *group, const char *name)
{
struct simple_children *simple_children;
Expand Down

0 comments on commit 22dd0e8

Please sign in to comment.