Skip to content

Commit

Permalink
[media] firedtv: fix remote control with newer Xorg evdev
Browse files Browse the repository at this point in the history
After a recent update of xf86-input-evdev and xorg-server, I noticed
that X11 applications did not receive keypresses from the FireDTV
infrared remote control anymore.  Instead, the Xorg log featured lots of

    "FireDTV remote control: dropping event due to full queue!"

exclamations.  The Linux console did not have an issue with the
FireDTV's RC though.

The fix is to insert EV_SYN events after the key-down/-up events.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Stefan Richter authored and Mauro Carvalho Chehab committed Jan 19, 2011
1 parent 3c61be4 commit 22f3771
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions drivers/media/dvb/firewire/firedtv-rc.c
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ void fdtv_unregister_rc(struct firedtv *fdtv)

void fdtv_handle_rc(struct firedtv *fdtv, unsigned int code)
{
u16 *keycode = fdtv->remote_ctrl_dev->keycode;
struct input_dev *idev = fdtv->remote_ctrl_dev;
u16 *keycode = idev->keycode;

if (code >= 0x0300 && code <= 0x031f)
code = keycode[code - 0x0300];
Expand All @@ -188,6 +189,8 @@ void fdtv_handle_rc(struct firedtv *fdtv, unsigned int code)
return;
}

input_report_key(fdtv->remote_ctrl_dev, code, 1);
input_report_key(fdtv->remote_ctrl_dev, code, 0);
input_report_key(idev, code, 1);
input_sync(idev);
input_report_key(idev, code, 0);
input_sync(idev);
}

0 comments on commit 22f3771

Please sign in to comment.