Skip to content

Commit

Permalink
ceph: move directory size logic to ceph_getattr
Browse files Browse the repository at this point in the history
We can't fill i_size with rbytes at the fill_file_size stage without
adding additional checks for directories.  Notably, we want st_blocks
to remain 0 on directories so that 'du' still works.

Fill in i_blocks, i_size specially in ceph_getattr instead.

Signed-off-by: Sage Weil <sage@newdream.net>
  • Loading branch information
Sage Weil committed Oct 21, 2009
1 parent bb097ff commit 232d4b0
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions fs/ceph/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -568,8 +568,6 @@ static int fill_inode(struct inode *inode,
queue_trunc = ceph_fill_file_size(inode, issued,
le32_to_cpu(info->truncate_seq),
le64_to_cpu(info->truncate_size),
S_ISDIR(inode->i_mode) ?
ci->i_rbytes :
le64_to_cpu(info->size));
ceph_fill_file_time(inode, issued,
le32_to_cpu(info->time_warp_seq),
Expand Down Expand Up @@ -1603,6 +1601,7 @@ int ceph_getattr(struct vfsmount *mnt, struct dentry *dentry,
struct kstat *stat)
{
struct inode *inode = dentry->d_inode;
struct ceph_inode_info *ci = ceph_inode(inode);
int err;

err = ceph_do_getattr(inode, CEPH_STAT_CAP_INODE_ALL);
Expand All @@ -1613,8 +1612,11 @@ int ceph_getattr(struct vfsmount *mnt, struct dentry *dentry,
stat->dev = ceph_snap(inode);
else
stat->dev = 0;
if (S_ISDIR(inode->i_mode))
if (S_ISDIR(inode->i_mode)) {
stat->size = ci->i_rbytes;
stat->blocks = 0;
stat->blksize = 65536;
}
}
return err;
}

0 comments on commit 232d4b0

Please sign in to comment.