Skip to content

Commit

Permalink
[TCP]: Add tcp_for_write_queue_from_safe and use it in mtu_probe
Browse files Browse the repository at this point in the history
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ilpo Järvinen authored and David S. Miller committed Jan 28, 2008
1 parent d67c58e commit 234b686
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
5 changes: 5 additions & 0 deletions include/net/tcp.h
Original file line number Diff line number Diff line change
Expand Up @@ -1229,6 +1229,11 @@ static inline struct sk_buff *tcp_write_queue_next(struct sock *sk, struct sk_bu
for (; (skb != (struct sk_buff *)&(sk)->sk_write_queue);\
skb = skb->next)

#define tcp_for_write_queue_from_safe(skb, tmp, sk) \
for (tmp = skb->next; \
(skb != (struct sk_buff *)&(sk)->sk_write_queue); \
skb = tmp, tmp = skb->next)

static inline struct sk_buff *tcp_send_head(struct sock *sk)
{
return sk->sk_send_head;
Expand Down
8 changes: 4 additions & 4 deletions net/ipv4/tcp_output.c
Original file line number Diff line number Diff line change
Expand Up @@ -1350,9 +1350,7 @@ static int tcp_mtu_probe(struct sock *sk)
tcp_insert_write_queue_before(nskb, skb, sk);

len = 0;
while (len < probe_size) {
next = tcp_write_queue_next(sk, skb);

tcp_for_write_queue_from_safe(skb, next, sk) {
copy = min_t(int, skb->len, probe_size - len);
if (nskb->ip_summed)
skb_copy_bits(skb, 0, skb_put(nskb, copy), copy);
Expand Down Expand Up @@ -1381,7 +1379,9 @@ static int tcp_mtu_probe(struct sock *sk)
}

len += copy;
skb = next;

if (len >= probe_size)
break;
}
tcp_init_tso_segs(sk, nskb, nskb->len);

Expand Down

0 comments on commit 234b686

Please sign in to comment.