Skip to content

Commit

Permalink
ide: move ide_setup_dma() call out from ->init_dma method
Browse files Browse the repository at this point in the history
There should be no functional changes caused by this patch.

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Apr 26, 2008
1 parent 6d36b95 commit 23658f8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
1 change: 0 additions & 1 deletion drivers/ide/pci/alim15x3.c
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,6 @@ static void __devinit init_dma_ali15x3 (ide_hwif_t *hwif, unsigned long dmabase)
{
if (!hwif->channel)
outb(inb(dmabase + 2) & 0x60, dmabase + 2);
ide_setup_dma(hwif, dmabase);
}

static const struct ide_port_ops ali_port_ops = {
Expand Down
2 changes: 0 additions & 2 deletions drivers/ide/pci/hpt366.c
Original file line number Diff line number Diff line change
Expand Up @@ -1348,8 +1348,6 @@ static void __devinit init_dma_hpt366(ide_hwif_t *hwif, unsigned long dmabase)
outb(dma_new, dmabase + 2);

local_irq_restore(flags);

ide_setup_dma(hwif, dmabase);
}

static void __devinit hpt374_init(struct pci_dev *dev, struct pci_dev *dev2)
Expand Down
7 changes: 3 additions & 4 deletions drivers/ide/setup-pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -361,11 +361,10 @@ void ide_hwif_setup_dma(ide_hwif_t *hwif, const struct ide_port_info *d)
}
}
if (dma_base) {
if (d->init_dma) {
if (d->init_dma)
d->init_dma(hwif, dma_base);
} else {
ide_setup_dma(hwif, dma_base);
}

ide_setup_dma(hwif, dma_base);
} else {
printk(KERN_INFO "%s: %s Bus-Master DMA disabled "
"(BIOS)\n", hwif->name, d->name);
Expand Down

0 comments on commit 23658f8

Please sign in to comment.